Pros
great benefits, excellent promotion opportunities. not a bad deal if you know what its going to be, but definitely don't just sign up and go into it based on what your recruiter tells you. you need to do your research, be careful about what specialty you pick, and go in with your eyes open because it should be no surprise at this point that you're going to deploy to the desert. your healthcare and retirement benefits are unmatched, so that's a huge bonus for people with families. however, you'll work hard to earn your money, especially when you are deployed.
Cons
lack of competence of upper level officers, unmotivated soldiers, difficulty in having your voice heard. its a huge organization and you are just a number to some extent. you will definitely be going to the desert somehow, and probably more frequently than you would like. you don't get much of a say in where they'll send you, so be prepared for surprises. not a bad deal overall, but not a great environment if you are looking to have a family or a life outside of the army. you will have to wake up every morning to work out, which is great except when you're tired, which is all the time.