Pros
Interesting industry to work in, complex policy challenges to deal with, nice and supportive atmosphere in the office, great location, benefits and perks, opportunities for professional developments (but rather horizontally than vertically). All previous reviews were correct for the situation several years ago but the organisation has done a really impressive transformation under the most recent leadership over the past 3-4 years. More young and dynamic people were hired, better management processes developed, the organisation has become more efficient in advocacy and communications both externally and towards membership. Granted, there are still issues and the situation can vary from department to department: some are modern, dynamic and try to be on the edge, some are still managed by dinosaurs. Good work-life balance, employees are really taken care of.
Cons
Upward mobility is difficult but this is the case for all trade associations. If you wan t to move up a ladder every 2 years, join a consultancy, this is not a place for you. But if you stick around, build relationship with key people, there are always ways for professional development and horizontal mobility or moving further to a member company.